Skip to content

Add additional security checks for GSS session encryption and GSS authentication #6525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vonzshik merged 2 commits into from
Apr 13, 2026
+15 −2
Merged

Add additional security checks for GSS session encryption and GSS authentication #6525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36b2e53
Add additional security checks for GSS session encryption and GSS aut…
vonzshik Mar 31, 2026
762cd93
Reference the issue
vonzshik Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/Npgsql/Internal/NpgsqlConnector.Auth.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,8 +330,14 @@ async Task AuthenticateMD5(string username, byte[] salt, bool async, Cancellatio
internal async ValueTask AuthenticateGSS(bool async, CancellationToken cancellationToken)
{
var targetName = $"{KerberosServiceName}/{Host}";
// See https://github.com/postgres/postgres/blob/a0dd0702e464f206b08c99a74cb58809c51aafa5/src/interfaces/libpq/fe-auth.c#L111-L123
// We do not support delegation (TokenImpersonationLevel.Delegation) for now (#6540)
var clientOptions = new NegotiateAuthenticationClientOptions
{
TargetName = targetName,
RequireMutualAuthentication = true
};

var clientOptions = new NegotiateAuthenticationClientOptions { TargetName = targetName };
NegotiateOptionsCallback?.Invoke(clientOptions);

using var authContext = new NegotiateAuthentication(clientOptions);
Expand Down
9 changes: 8 additions & 1 deletion src/Npgsql/Internal/NpgsqlConnector.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,7 +605,14 @@ internal async ValueTask<GssEncryptionResult> GSSEncrypt(bool async, bool isRequ
ConnectionLogger.LogTrace("Negotiating GSS encryption");

var targetName = $"{KerberosServiceName}/{Host}";
var clientOptions = new NegotiateAuthenticationClientOptions { TargetName = targetName };
// See https://github.com/postgres/postgres/blob/a0dd0702e464f206b08c99a74cb58809c51aafa5/src/interfaces/libpq/fe-secure-gssapi.c#L651-L658
// We do not support delegation (TokenImpersonationLevel.Delegation) for now (#6540)
var clientOptions = new NegotiateAuthenticationClientOptions
{
TargetName = targetName,
RequireMutualAuthentication = true,
RequiredProtectionLevel = ProtectionLevel.EncryptAndSign
};

NegotiateOptionsCallback?.Invoke(clientOptions);

Expand Down
Loading