Skip to content

Add basic testing for tracing #6051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vonzshik merged 7 commits into from
Mar 20, 2025
Merged

Add basic testing for tracing #6051

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1627ef1
Add basic testing for tracing
vonzshik Mar 16, 2025
c8af841
Add a few more tests
vonzshik Mar 17, 2025
be733c4
Also test batches
vonzshik Mar 17, 2025
ddb3b66
Set status on Activity
vonzshik Mar 17, 2025
0ad520f
Do not set otel tags explicitly
vonzshik Mar 19, 2025
ceea7dd
Fix tests
vonzshik Mar 19, 2025
e01b396
A few more test fixes
vonzshik Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
A few more test fixes
  • Loading branch information
@vonzshik
vonzshik committed Mar 19, 2025
commit e01b3967ce58a87d5fd231d2bb16d3db1e760577
11 changes: 1 addition & 10 deletions test/Npgsql.Tests/TracingTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public async Task Basic([Values] bool async, [Values] bool batch)
var firstResponseEvent = activity.Events.First();
Assert.That(firstResponseEvent.Name, Is.EqualTo("received-first-response"));

var expectedTagCount = conn.Settings.Port == 5432 ? 8 : 9;
var expectedTagCount = conn.Settings.Port == 5432 ? 9 : 10;
Assert.That(activity.TagObjects.Count(), Is.EqualTo(expectedTagCount));

var queryTag = activity.TagObjects.First(x => x.Key == "db.statement");
Expand All @@ -60,9 +60,6 @@ public async Task Basic([Values] bool async, [Values] bool batch)
var connIDTag = activity.TagObjects.First(x => x.Key == "db.connection_id");
Assert.That(connIDTag.Value, Is.EqualTo(conn.ProcessID));
}

var statusTag = activity.TagObjects.First(x => x.Key == "otel.status_code");
Assert.That(statusTag.Value, Is.EqualTo("OK"));
}

[Test]
Expand Down Expand Up @@ -131,12 +128,6 @@ public async Task Error([Values] bool async, [Values] bool batch)
var connIDTag = activity.TagObjects.First(x => x.Key == "db.connection_id");
Assert.That(connIDTag.Value, Is.EqualTo(conn.ProcessID));
}

var statusTag = activity.TagObjects.First(x => x.Key == "otel.status_code");
Assert.That(statusTag.Value, Is.EqualTo("ERROR"));

var descriptionTag = activity.TagObjects.First(x => x.Key == "otel.status_description");
Assert.That(descriptionTag.Value, Is.EqualTo(PostgresErrorCodes.UndefinedTable));
}

[Test]
Expand Down