Skip to content

Limit number of authentication attempts #6030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ecrocombe wants to merge 8 commits into
base: main
Choose a base branch
from
+37 −21
Open

Limit number of authentication attempts #6030

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f57684a
limit auth attempts
ecrocombe Feb 26, 2025
41b6400
correct comments
ecrocombe Feb 26, 2025
8482cad
Add refs to issues
ecrocombe Feb 26, 2025
c3c3995
format multiple issues into list
ecrocombe Feb 26, 2025
fd43cf1
more of those text stuffs
ecrocombe Feb 26, 2025
f87871d
reduce auth attempts
ecrocombe Feb 26, 2025
acff8cf
change error message
ecrocombe Feb 26, 2025
d084c29
remove double timeout check, also use correct operator to guage attem…
ecrocombe Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
change error message
  • Loading branch information
@ecrocombe
ecrocombe committed Feb 26, 2025
commit acff8cfc77b94dd352315103198be49f526395a3
2 changes: 1 addition & 1 deletion src/Npgsql/Internal/NpgsqlConnector.Auth.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ await AuthenticateSASL(((AuthenticationSASLMessage)msg).Mechanisms, username, as
}

// If we made it this far, authentication failed to occur within the specified timeout, or attempt limit.
throw new NpgsqlException($"Authentication cycle timed out after {attempt} attempts.");
throw new NpgsqlException($"Authentication cycle failed to complete successfully after {attempt} attempts.");
}

async Task AuthenticateCleartext(string username, bool async, CancellationToken cancellationToken = default)
Expand Down