Cleanup fully qualified name lookup code - #5311
Merged
Merged
Conversation
NinoFloris
force-pushed
the
cleanup-fq-lookup
branch
from
November 14, 2023 18:43
243b6c7 to
9e88279
Compare
vonzshik
approved these changes
Nov 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move resolving the fully qualified name to just one place, when a match is found.
For composed factories (array mappings mostly) we now push the resolved schema directly into the inner mapping datatypename, an improvement over what we currently do. There will just be the one lookup that could potentially run into exceptions like "More than one PostgreSQL type was found with the name ... please specify a full name including schema:"