Skip to content

Implement batching error barrier control - #4674

Merged
roji merged 3 commits into
npgsql:mainfrom
roji:BatchingIsolation
Sep 25, 2022
Merged

Implement batching error barrier control#4674
roji merged 3 commits into
npgsql:mainfrom
roji:BatchingIsolation

Conversation

@roji

@roji roji commented Sep 23, 2022

Copy link
Copy Markdown
Member

Closes #4205

@roji
roji requested a review from vonzshik as a code owner September 23, 2022 14:35
Comment thread src/Npgsql/NpgsqlBatchCommand.cs Outdated
/// </para>
/// <para>
/// Controlling error barriers on a command-by-command basis is an advanced feature, considering enabling error barriers for the
/// entire batch via <see cref="NpgsqlBatch.EnableErrorBarriers" />.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@roji
roji force-pushed the BatchingIsolation branch from af2ab7e to b5361fa Compare September 23, 2022 14:48
@roji

roji commented Sep 23, 2022

Copy link
Copy Markdown
Member Author

Thanks @NinoFloris! @vonzshik @Brar will wait a bit for any comments you have too.

@roji

roji commented Sep 23, 2022

Copy link
Copy Markdown
Member Author

/cc @ajcvickers

@roji
roji force-pushed the BatchingIsolation branch from b5361fa to 3a025fa Compare September 23, 2022 18:15
@Brar

Brar commented Sep 24, 2022

Copy link
Copy Markdown
Member

I didn't look at the details of the implementation yet, but I like the API.

Comment thread src/Npgsql/Util/PGUtil.cs Outdated
Comment thread src/Npgsql/NpgsqlCommand.cs
Comment thread src/Npgsql/NpgsqlDataReader.cs
@roji
roji requested a review from vonzshik September 25, 2022 12:43
@roji
roji merged commit 449f1e0 into npgsql:main Sep 25, 2022
@roji
roji deleted the BatchingIsolation branch September 25, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow specifying error barriers (Syncs) in an NpgsqlBatch (with Syncs)

4 participants