Skip to content

Prepend and quote savepoints#3263

Merged
roji merged 1 commit into
npgsql:mainfrom
roji:PrependSavepoints
Nov 1, 2020
Merged

Prepend and quote savepoints#3263
roji merged 1 commit into
npgsql:mainfrom
roji:PrependSavepoints

Conversation

@roji
Copy link
Copy Markdown
Member

@roji roji commented Oct 23, 2020

Note: this is based off of #3253 for some mocking infrastructure stuff. When reviewing, look only at the last commit.

Closes #2892
Closes #3262

@roji roji requested a review from YohDeadfall as a code owner October 23, 2020 10:50
@roji roji force-pushed the PrependSavepoints branch from ad6d1d7 to dd11506 Compare October 23, 2020 10:59
Comment thread src/Npgsql/NpgsqlTransaction.cs Outdated
Comment thread src/Npgsql/NpgsqlTransaction.cs Outdated
Comment thread test/Npgsql.Tests/Support/PgPostmasterMock.cs Outdated
@roji roji force-pushed the PrependSavepoints branch from af14c62 to 74746d3 Compare October 25, 2020 13:41
@roji
Copy link
Copy Markdown
Member Author

roji commented Oct 25, 2020

Rebased off of main after merging #3253 and the other PRs.

@roji
Copy link
Copy Markdown
Member Author

roji commented Nov 1, 2020

@npgsql/core anyone up for a review?

@roji roji force-pushed the PrependSavepoints branch from 80c898a to 6d01053 Compare November 1, 2020 15:59
@roji roji merged commit d071035 into npgsql:main Nov 1, 2020
@roji roji deleted the PrependSavepoints branch November 1, 2020 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Properly quote savepoint names Savepoint creation should prepend rather than doing a network roundtrip

2 participants