Set timeouts for COPY operations#3151
Merged
Merged
Conversation
8ceddcb to
9361895
Compare
3a35181 to
74ef221
Compare
Contributor
Author
|
|
Member
Contributor
Author
Member
|
Ah of course :) OK, will let you rebase/clean up :) |
74ef221 to
3db9087
Compare
Contributor
Author
|
@roji okay, it's ready now. Although, maybe we should go over other COPY operations as well (handle exceptions). |
roji
approved these changes
Nov 9, 2020
Member
roji
left a comment
There was a problem hiding this comment.
LGTM but let's consider TimeSpan instead of int for new properties.
We should ideally have a dedicated test for the timeouts, but that requires evolving the PG mock a bit. We can postpone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1328