Skip to content

Handle IEnumerable<int> parameter#225

Merged
franciscojunior merged 2 commits into
npgsql:masterfrom
danzel:fix-222
May 8, 2014
Merged

Handle IEnumerable<int> parameter#225
franciscojunior merged 2 commits into
npgsql:masterfrom
danzel:fix-222

Conversation

@danzel
Copy link
Copy Markdown
Contributor

@danzel danzel commented May 4, 2014

WriteEnumeration would use Square braces instead of Curly braces, in comparison WriteArray always uses Curly braces.
I've changed WriteEnumeration to always use Curly to match.

Not 100% sure if this is the right fix, but works for this case. I've added a test.
Fixes #222

@franciscojunior
Copy link
Copy Markdown
Member

Thanks for your patch, @danzel !

@glenebob , can you please check if it is ok? It seems brackets are being used when not using prepared statements which is giving errors. Maybe those brackets were there to be used with array constructor syntax? http://www.postgresql.org/docs/9.1/static/sql-expressions.html#SQL-SYNTAX-ARRAY-CONSTRUCTORS

@franciscojunior
Copy link
Copy Markdown
Member

After checking the documentation, http://www.postgresql.org/docs/8.4/static/arrays.html the bracket notation is only used when the string ARRAY is written before the array. i.e.: (from postgresql documentation)

INSERT INTO sal_emp
    VALUES ('Bill',
    ARRAY[10000, 10000, 10000, 10000],
    ARRAY[['meeting', 'lunch'], ['training', 'presentation']]);

I think this notation format was left there by mistake because we used to use this notation but we don't use it anymore.

I conclude then that the fix proposed is correct. Merging now...

While doing the tests, I noticed another bug in Npgsql with prepared statements and IEnumerable

@franciscojunior franciscojunior added this to the 2.2 milestone May 8, 2014
franciscojunior added a commit that referenced this pull request May 8, 2014
Handle IEnumerable<int> parameter
@franciscojunior franciscojunior merged commit fe7fba2 into npgsql:master May 8, 2014
roji added a commit to roji/Npgsql that referenced this pull request Apr 12, 2019
PostgreSQL only supports a single transaction on a given connection at
a given time; as a result, Npgsql largely ignores DbCommand.Transaction.
This commit removes some useless partial checks.

Also disable related specification tests (part of npgsql#225).
roji added a commit that referenced this pull request Apr 14, 2019
PostgreSQL only supports a single transaction on a given connection at
a given time; as a result, Npgsql largely ignores DbCommand.Transaction.
This commit removes some useless partial checks.

Also disable related specification tests (part of #225).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants