Skip to content

Fix #177. Add proper quoting to xml datatype. #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojunior merged 1 commit into from
Jun 9, 2014
Merged

Fix #177. Add proper quoting to xml datatype. #212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Npgsql/NpgsqlTypes/NpgsqlTypesHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,9 @@ private static NpgsqlNativeTypeMapping PrepareDefaultTypesMap()
nativeTypeMapping.AddType("uuid", NpgsqlDbType.Uuid, DbType.Guid, true);
nativeTypeMapping.AddTypeAlias("uuid", typeof (Guid));

nativeTypeMapping.AddType("xml", NpgsqlDbType.Xml, DbType.Xml, true);
nativeTypeMapping.AddType("xml", NpgsqlDbType.Xml, DbType.Xml, false,
BasicNativeToBackendTypeConverter.StringToTextText,
BasicNativeToBackendTypeConverter.StringToTextBinary);

nativeTypeMapping.AddType("interval", NpgsqlDbType.Interval, DbType.Object, true,
ExtendedNativeToBackendTypeConverter.ToInterval);
Expand Down
32 changes: 32 additions & 0 deletions tests/CommandTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1731,6 +1731,38 @@ public void TestCircleSupport()
Assert.AreEqual(5, circle.Radius);
}

[Test]
public void TestXmlParameter()
{
TestXmlParameter_Internal(false);
}

[Test]
public void TestXmlParameterPrepared()
{
TestXmlParameter_Internal(true);
}


private void TestXmlParameter_Internal(bool prepare)
{
using (var command = new NpgsqlCommand("select @PrecisionXML", Conn))
{
var sXML = "<?xml version=\"1.0\" encoding=\"UTF-8\"?> <strings type=\"array\"> <string> this is a test with ' single quote </string></strings>";
var parameter = command.CreateParameter();
parameter.DbType = DbType.Xml; // To make it work we need to use DbType.String; and then CAST it in the sSQL: cast(@PrecisionXML as xml)
parameter.ParameterName = "@PrecisionXML";
parameter.Value = sXML;
command.Parameters.Add(parameter);

if (prepare)
command.Prepare();
command.ExecuteScalar();
}

}


[Test]
public void SetParameterValueNull()
{
Expand Down