Skip to content

Update korean.xml to 8.9.6 version#18082

Open
BasicsBasic wants to merge 2 commits into
notepad-plus-plus:masterfrom
BasicsBasic:patch-1
Open

Update korean.xml to 8.9.6 version#18082
BasicsBasic wants to merge 2 commits into
notepad-plus-plus:masterfrom
BasicsBasic:patch-1

Conversation

@BasicsBasic
Copy link
Copy Markdown

added new messages, fixed some typo (e.g. RenameTabTemporaryNameIsEmpry), improved consistency through translations

added new messages, fixed some typo (e.g. RenameTabTemporaryNameIsEmpry), improved consistency through translations
@chcg chcg added the translation Issues or PRs related to translation of N++ UI label May 29, 2026
@BasicsBasic
Copy link
Copy Markdown
Author

Okay that was the first time, I'll read the instruction and try again.
maybe "Please install XML Tools plugin~" was the problem.

@GOLEM777
Copy link
Copy Markdown
Contributor

GOLEM777 commented May 30, 2026

No ( " ) must be in front and in end. Your (&r) remained in between.
Example: ="any text"/>
edit it like this:
<Item id="44097" name="모니터링 (tail -f)(&amp;r)"/>

Just edit the current translation and delete the duplicate.

fixed <Item id="44097" name="모니터링 (tail -f)(&amp;r)"/>
<Item id="6908" name="선택된 텍스트로 찾기 창 채우기"/>
<Item id="6909" name="아무 것도 선택되지 않으면 커서 아래의 단어 선택"/>
<Item id="6910" name="&quot;선택 안&quot;에서 자동 검사 최소 크기:"/>
<Item id="6910" name="&quot;선택 범위 내quot;에서 자동 검사 최소 크기:"/>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One &quot; is mistyped here (& is missing)

<localization work version="7.8.1~8.6.9" nick="Sapziller" name="ByungJo Yoon" mail="yunbj@naver.com"/> <localization work version=6.5.3~7.4.2 name="도움돌" mail= "domddol@gmail.com"/> <localization work version=1 and 6.1.5 nick= "taggon" name= "Taegon Kim" mail= "gonom9@gmail.com"/> <localization work version=2 nick= "" name= "JiHui Choi" mail= "jihui.choi@gmail.com"/> <localization work version=5.4R2 nick= "DreamFactory7" name= "JongPil Kim" mail= "kmshts@naver.com"/> <localization work version=4 nick= "Sapziller" name= "Byungjo Yoon" mail= "yunbj@naver.com"/> <localization work version=5.8 nick= "DreamFactory7" name= "JongPil Kim" mail= "kmshts@naver.com"/> <localization work version=5.9 nick= "Syonsi" name= "Kim JunHo" mail= "syonsi@live.com"/> <localization work version=5.92 nick= "Global DOL+I" name= "Lee Junho" mail= "riifjv@live.com"/>
<localization work version="8.9.6" name= "YoungUk Song" mail= "sdkncu1342@gmail.com"/> <localization work version="7.8.1~8.6.9" nick="Sapziller" name="ByungJo Yoon" mail="yunbj@naver.com"/> <localization work version=6.5.3~7.4.2 name="도움돌" mail= "domddol@gmail.com"/> <localization work version=1 and 6.1.5 nick= "taggon" name= "Taegon Kim" mail= "gonom9@gmail.com"/> <localization work version=2 nick= "" name= "JiHui Choi" mail= "jihui.choi@gmail.com"/> <localization work version=5.4R2 nick= "DreamFactory7" name= "JongPil Kim" mail= "kmshts@naver.com"/> <localization work version=4 nick= "Sapziller" name= "Byungjo Yoon" mail= "yunbj@naver.com"/> <localization work version=5.8 nick= "DreamFactory7" name= "JongPil Kim" mail= "kmshts@naver.com"/> <localization work version=5.9 nick= "Syonsi" name= "Kim JunHo" mail= "syonsi@live.com"/> <localization work version=5.92 nick= "Global DOL+I" name= "Lee Junho" mail= "riifjv@live.com"/>
-->
<NotepadPlus>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, found it, because the missing & could not be the cause of the build failure.

You accidentially removed the beginning <NotepadPlus> tag.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BasicsBasic
Please follow the suggestions to fix invalid XML that you committed in the PR.

Copy link
Copy Markdown
Member

@donho donho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make XML validate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

translation Issues or PRs related to translation of N++ UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants