This repository was archived by the owner on Feb 20, 2021. It is now read-only.
add support for Node.js 12 on UBI8#213
Closed
danbev wants to merge 3 commits intonodeshift-archived:v12.x-stagingfrom
Closed
add support for Node.js 12 on UBI8#213danbev wants to merge 3 commits intonodeshift-archived:v12.x-stagingfrom
danbev wants to merge 3 commits intonodeshift-archived:v12.x-stagingfrom
Conversation
This commit adds the rpmdevtools rpms to this repository as I've failed to find them in a repository for RHEL8 anywhere. Docker will copy these and then install them.
ead0568 to
241d7be
Compare
lance
approved these changes
May 14, 2019
Contributor
lance
left a comment
There was a problem hiding this comment.
Just one question. Otherwise LGTM.
| libicu-devel \ | ||
| procps-ng \ | ||
| python2-devel \ | ||
| python3-devel \ |
Contributor
There was a problem hiding this comment.
Why both Python 2 and 3? I haven't built Node 12 yet. Has it moved to Python 3?
Contributor
Author
There was a problem hiding this comment.
There is one script in V8 which I believe needs Python3. I'm not 100% about the details as this was something that Yaakov provided in his work. The goal is to migrate all the scrips to Python3 eventually so I think we'll have to live with Python2 for a while still.
Member
There was a problem hiding this comment.
Extra information about python 2x support:
python/devguide#344
This commit introduces a quiet variable to the spec file and if it is set to true (1) then the complete output of the make test command will be redirected to /dev/null. This is done as currently there will still be output written to Travis log even if a silent build is requested.
helio-frota
approved these changes
May 15, 2019
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds the rpmdevtools rpms to this repository as I've failed
to find them in a repository for RHEL8 anywhere. Docker will copy these
and then install them.