Feature/migration#210
Merged
kt3k merged 49 commits intonodejsjp:masterfrom Nov 13, 2016
Merged
Conversation
Update nunjucks to the latest version 🚀
hiroppy
reviewed
Nov 12, 2016
| url: https://www.google.com/ | ||
| --- | ||
|
|
||
| 当社は1945年設立、2011年マザーズ上場の若い企業で、街コンワールド( http://machicon-world.com/ )という街コンポータルサイトを運営しています。 |
Member
Author
There was a problem hiding this comment.
あー、すみません、求人情報データは架空データなので、消さ無いとダメでした。消します。
指摘ありがとうございます。 🙇
Member
Author
There was a problem hiding this comment.
ダミー求人データを消しました。デモサイトの方で確認できます。 https://kt3k.github.io/asdfghjs.jp/jobboard.html
この行自体は README の中のサンプルなので、そのままにしておきます。
hiroppy
reviewed
Nov 12, 2016
| <link type="text/css" rel="stylesheet" href="style.css" /> | ||
| <link type="text/css" rel="stylesheet" href="http://nodejs.jp/nodejs.org_ja/sh_vim-dark.css" /> | ||
| <script src="http://nodejs.jp/nodejs.org_ja/sh_main.js"></script> | ||
| <script src="http://nodejs.jp/nodejs.org_ja/sh_javascript.min.js"></script> |
Member
There was a problem hiding this comment.
問題なければscriptタグはbodyの最後にしたほうがいいと思います:)
Member
Author
There was a problem hiding this comment.
動作確認したところ、後ろに下げても問題なさそうだったので、下げます。指摘ありがとうございます!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://iojs-jp.slack.com/messages/nodejsjp/ の方で議論しているリニューアルの PR です。
デモサイト
https://kt3k.github.io/asdfghjs.jp/
マージ前作業:
マージ後作業:
Note: この PR にマージ後 上 (手順2) 完了までは、一瞬サイトが表示でき無い状態になります
bulbofile.js でアセットのビルド方法を指定して、開発時は
npm run serveで確認可。build 時は同内容が、npm run build でビルドされる、という構成です。(詳しくは README 参照)