fix(svgx): include now-required import attribute for text - #380
Open
JakobJingleheimer wants to merge 1 commit into
Open
fix(svgx): include now-required import attribute for text#380JakobJingleheimer wants to merge 1 commit into
JakobJingleheimer wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the SVGX loader to stay compatible with Node.js’s native type: "text" import-attribute requirement for text-format loads, by injecting the appropriate importAttributes when delegating to nextLoad.
Changes:
- Pass
importAttributes: { type: 'text' }(merging any existing attributes) when callingnextLoadwithformat: 'text'for.svgfiles. - Preserve prior behavior for non-
.svgfiles and downstream JSX transformation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+34
to
+38
| nextLoad(url, { | ||
| ...ctx, | ||
| format: 'text', | ||
| importAttributes: { ...ctx.importAttributes, type: 'text' }, | ||
| }), |
Member
|
@JakobJingleheimer it's still not working |
Member
Author
|
Yes, I know. I think node's handling of text imports (nodejs/node#62300) is b0rked: import './fixture.svg';import './fixture.svg' with { type: 'text' };I posted in |
Member
|
oh sad ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #381
This injects the now-required import attribute.