ignore failures building all recipes but fetch-source#10
Merged
rvagg merged 1 commit intonodejs:masterfrom Oct 1, 2019
Merged
Conversation
3 tasks
Member
Unofficial builds of v12.11.0 failed because they build from the source tarball which is broken (nodejs/node#29709). nodejs/node#29712 fixed the source tarball generation but would need a new release. That's not to say the idea here of not allowing one failing recipe to block the others isn't a good idea. |
Member
|
yeah, what @richardlau said, I manually edited this file on the server and removed x86 and then musl failed, which is why nodejs/node#29709 turned from "x86 is broken" to "it's all broken". But you're right, this has been a TODO |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v12.11.0 was not published because of a failure building x86. Until that is fixed it is blocking other recipes and promotion of assets. This PR changes
build.shto keep building other recipes when one fails.This was not tested, I will fix any issue if we agree this is the way to move forward.
cc @rvagg