chore: use node 22 Set methods for websocket close state#4974
Closed
trivikr wants to merge 1 commit intonodejs:mainfrom
Closed
chore: use node 22 Set methods for websocket close state#4974trivikr wants to merge 1 commit intonodejs:mainfrom
trivikr wants to merge 1 commit intonodejs:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4974 +/- ##
=======================================
Coverage 93.09% 93.09%
=======================================
Files 110 110
Lines 35801 35811 +10
=======================================
+ Hits 33330 33340 +10
Misses 2471 2471 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aca3345 to
552af7a
Compare
Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Member
I don't agree and the code doesn't agree either. You wouldn't need to partially explain set theory in the comment if it was explicit. Having to duplicate the states in a new set is also just not good code. |
Member
Author
Closing as this change is not good code, according to one of the maintainers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
N/A
Rationale
Node.js 22 supports the new
Setrelation methods, which make the WebSocket closing-handshake checks more explicit. This change centralizes the closing-handshake state set in the WebSocket constants module and reuses it across the WebSocket implementation instead of redefining it in multiple files.Changes
closingHandshakeStatesto the WebSocket constants moduleclosingHandshakeStateswith JSDocSet.prototype.isDisjointFrom()andSet.prototype.isSupersetOf()for closing-handshake checksFeatures
N/A
Bug Fixes
N/A
Breaking Changes and Deprecations
N/A
Status