chore(ui): reduce prod deps#8955
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryMedium Risk Overview Build/deploy wiring: Root and package Site styling: Reviewed by Cursor Bugbot for commit 5e1314c. Bugbot is set up for automated code reviews on this repo. Configure here. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8955 +/- ##
==========================================
- Coverage 75.70% 75.38% -0.32%
==========================================
Files 102 98 -4
Lines 8676 8630 -46
Branches 321 318 -3
==========================================
- Hits 6568 6506 -62
- Misses 2105 2120 +15
- Partials 3 4 +1 ☔ View full report in Codecov by Harness. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ad9ae44. Configure here.
| "tasks": { | ||
| "dev": { | ||
| "dependsOn": ["build:blog-data"], | ||
| "dependsOn": ["build:blog-data", "build:twoslash-fsmap", "^build"], |
There was a problem hiding this comment.
Deploy task omits dependency build
Medium Severity
The site deploy Turbo task does not depend on ^build, unlike build and dev. With @node-core/ui-components default exports now targeting dist, running pnpm deploy alone can start Next before dist exists and fail module resolution.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit ad9ae44. Configure here.
Can we make sure that post-build, we prune back to just production runtime dependencies? |
|
I believe vercel does that post-build anyway, it only ships the built |
|
Does it bundle everything for server-side logic too? |
This change pre-bundles |
|
Right, but I don't really want any dev deps hanging around in node_modules after we've done the initial build |
It shouldn't matter what's in |
|
That's what I was asking, to check that it is just that output that's used, and that node_modules doesn't persist for server-side dependencies 🤔 |
|
Ahh sorry if I misunderstood. No, |
This PR makes
@node-core/ui-componentsship a precompileddist/and consume it from the site, instead of the site transpiling the package's raw source. As a result, the package's build-only tooling (typescript,tailwindcss,postcss-*,@tailwindcss/postcss,@types/react) moves fromdependenciestodevDependencies, where it belongs.