Conversation
Member
|
@nodejs/release if someone does a release before this lands you might want to check it out and give it a try |
|
|
||
| return sendRequest({ | ||
| url: `https://raw.githubusercontent.com/nodejs/node/master/doc/changelogs/CHANGELOG_V${ | ||
| parts[0] === '0' ? parts.slice(0, 2).join('') : parts[0] |
Member
There was a problem hiding this comment.
Could this be extracted into a descriptive variable to increase readability?
Member
|
Sorry for not reviewing this earlier! Other than my inline comments, SGTM. Would have been nice to get it tested and confirmed by someone in @nodejs/release before merging it though. |
Member
Author
|
I'll address the comments tomorrow. |
Member
Author
|
Updated. |
Merged
Member
|
LGTM. I tested it with the latest versions from each release lines, seems to be working perfectly 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the
release-postscript to make it work with the new changelog structure.It currently only works with:
CHANGELOG_V0{10,12}.mdCHANGELOG_V{4,5,6}.md