Create Notification Component#5955
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Unit Test Coverage Report
Unit Test Report
|
mikeesto
reviewed
Oct 3, 2023
ovflowd
reviewed
Oct 3, 2023
ovflowd
reviewed
Oct 3, 2023
ovflowd
reviewed
Oct 3, 2023
ovflowd
reviewed
Oct 3, 2023
ovflowd
approved these changes
Oct 3, 2023
ovflowd
left a comment
Member
There was a problem hiding this comment.
Code-wise, LGTM! Waiting for that emitter, but thank you so much for your contribution!
Also if you could rebase the brabhc :)
ovflowd
reviewed
Oct 3, 2023
ovflowd
reviewed
Oct 3, 2023
ovflowd
reviewed
Oct 5, 2023
ovflowd
reviewed
Oct 5, 2023
ovflowd
reviewed
Oct 6, 2023
ovflowd
reviewed
Oct 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Created a Notification based on the requirements from the issue.
Provider&Viewportinpreview.tsxNote:
In Storybook, the component will appear at the bottom right of the viewport. So it will not be immediately visible, you just need to scroll down a bit 😊
Validation
Related Issues
Resolves 5948
Check List
npx turbo lintto ensure the code follows the style guide. And runnpx turbo lint:fixto fix the style errors if necessary.npx turbo formatto ensure the code follows the style guide.npx turbo testto check if all tests are passing.