Skip to content

feat: remove codebox component#5713

Merged
ovflowd merged 2 commits into
nodejs:mainfrom
araujogui:feat/remove-codebox
Aug 31, 2023
Merged

feat: remove codebox component#5713
ovflowd merged 2 commits into
nodejs:mainfrom
araujogui:feat/remove-codebox

Conversation

@araujogui
Copy link
Copy Markdown
Member

@araujogui araujogui commented Aug 29, 2023

Description

Remove CodeBox component

Related Issues

Fixes #5700

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I've covered new added functionality with unit tests if necessary.

@araujogui araujogui requested a review from a team as a code owner August 29, 2023 19:00
@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 29, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2023 7:02pm

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 29, 2023

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 93%
 92.81% (297/320) 79.71% (55/69) 88.23% (60/68)

Unit Test Report

Tests Skipped Failures Errors Time
32 0 💤 0 ❌ 0 🔥 9.159s ⏱️

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 29, 2023

📦 Next.js Bundle Analysis for nodejs.org

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

HinataKah0
HinataKah0 approved these changes Aug 30, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@HinataKah0 HinataKah0 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit:
@araujogui I just realized that vendor/prism-tomorrow might be related to Prism JS. Since this PR is removing the Prism JS dependency, can you verify if it's truly safe to remove?

I didn't retract because it didn't seem to break anything.
LGTM! It seems that PrismJS is used by this component only so, should be safe to delete.

@ovflowd
Copy link
Copy Markdown
Member

ovflowd commented Aug 30, 2023

Edit: @araujogui I just realized that vendor/prism-tomorrow might be related to Prism JS. Since this PR is removing the Prism JS dependency, can you verify if it's truly safe to remove?

I didn't retract because it didn't seem to break anything. LGTM! It seems that PrismJS is used by this component only so, should be safe to delete.

This seems actually to be used by HighlightJS. It's not really from PrismJS (I mean, the theme is done by PrismJS, but actually being used on the current nodejs.org highlight.js implementation)

@ovflowd ovflowd added this pull request to the merge queue Aug 31, 2023
Merged via the queue into nodejs:main with commit 21384f6 Aug 31, 2023
@bmuenzenmeyer bmuenzenmeyer mentioned this pull request Sep 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ovflowd ovflowd ovflowd approved these changes

+2 more reviewers

@rodion-arr rodion-arr rodion-arr approved these changes

@HinataKah0 HinataKah0 HinataKah0 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Delete Codebox Component

4 participants

@araujogui @ovflowd @rodion-arr @HinataKah0