Skip to content

finish removing analytics and related helper #2309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Trott merged 1 commit into from
Jul 1, 2019
Merged

finish removing analytics and related helper #2309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
finish removing analytics and related helper 
It was still present in one file, previous
commit just removed the prefetch.

Also remove dnt_helper, it was used only by analytics.

Refs: #2305
Refs: nodejs/node#23083
Refs: nodejs/node#22652
Refs: #2302
  • Loading branch information
@ChALkeR
ChALkeR committed Jul 1, 2019
commit d348e9b74bea5811dad3e27bcecba77f105103b7
17 changes: 0 additions & 17 deletions external/survey-2018/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2245,22 +2245,5 @@ <h4><i>(Top Impacts)</i></h4>
<script src="d3.v3.min.js"></script>
<script src="data.min.js"></script>
<script src="full.min.js"></script>

<script src="/static/js/dnt_helper.js"></script>
<script>
(function(){
if (!_dntEnabled()) {
!function(n,o,d,e,j,s){n.GoogleAnalyticsObject=d;n[d]||(n[d]=function(){
(n[d].q=n[d].q||[]).push(arguments)});n[d].l=+new Date;j=o.createElement(e);
s=o.getElementsByTagName(e)[0];j.async=1;j.src='//www.google-analytics.com/analytics.js';
s.parentNode.insertBefore(j,s)}(window,document,'ga','script');

if (!ga) return;

ga('create', 'UA-67020396-1', 'auto');
ga('send', 'pageview');
}
})();
</script>
</body>
</html>
2 changes: 0 additions & 2 deletions layouts/partials/footer.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,5 +51,3 @@
s.parentNode.insertBefore(m,s);
})(document,'script');
</script>

<script src="/static/js/dnt_helper.js"></script>
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
"standard": {
"ignore": [
"static/js/modernizr.custom.js",
"static/js/dnt_helper.js",
"static/legacy/*",
"external"
]
Expand Down
48 changes: 0 additions & 48 deletions static/js/dnt_helper.js
View file
Open in desktop

This file was deleted.