Update knowledge/how to use nodejs repl - #2156
Merged
4 commits merged intoMar 28, 2019
Merged
Conversation
ghost
approved these changes
Mar 19, 2019
ghost
left a comment
There was a problem hiding this comment.
LGTM, thanks!
waiting others' suggestions :)
Contributor
|
LGTM, 🙌 |
ghost
requested a review
from fhemberger
March 26, 2019 10:34
Contributor
I think it should be |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to the knowledge article how to use nodejs repl.
This is the first of several articles I will be editing #1977 (comment). Any feedback is welcome.
And to jumpstart that:
Is it acceptable that I added sectional headers?
I think it helps the reader survey the content quicker, but very few of these knowledge articles use headers at all currently. My inclination is to add them to articles I edit. Please let me know if I shouldn't bother for any reason.
Edit: Also, any guidance on how I should handle linking between these articles? I wanted to link to the next article, "how to create a custom repl" from this one, but wasn't sure the convention. So I linked to the Node API docs instead.
shellsyntax.cc @fhemberger @keywordnew