Fix for non-clickable area on Search result#3217
Conversation
Codecov ReportBase: 66.02% // Head: 66.25% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #3217 +/- ##
==========================================
+ Coverage 66.02% 66.25% +0.23%
==========================================
Files 118 145 +27
Lines 1351 1716 +365
Branches 342 398 +56
==========================================
+ Hits 892 1137 +245
- Misses 422 534 +112
- Partials 37 45 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Please find a preview at: https://staging.nodejs.dev/3217/ |
benhalverson
left a comment
There was a problem hiding this comment.
This doesn't look right. It's hard to read the text when you hover over any result.
|
I don't get it. It shows up like this.
What is suggestion? Should we have just outline on hover instead of changing background? |
You probably need to check both the light version and the dark version of the UI. |
|
@junwen-k : Thanks for helping.. Yes, it did not look that good in dark version.. I have removed the background color on hover. @benhalverson @AugustinMauroy Light version: Dark version: |
AugustinMauroy
left a comment
There was a problem hiding this comment.
Nice better thanks I don't see any new problem
|
Please find a preview at: https://staging.nodejs.dev/3217/ |
Description
Fix for https://github.com/nodejs/nodejs.dev/issues/3208 issue. Now, complete area is highlighted and made clickable.
Related Issues
Check List
npm run lint:js -- --fixand/ornpm run lint:md -- --fixfor my JavaScript and/or Markdown changes.npm run testto check if all tests are passing, and/ornpm run test -- -uto update snapshots if I created and/or updated React Components.npm run buildwork fine.