This repository was archived by the owner on Apr 26, 2024. It is now read-only.
chore: add npm ecosystem for dependabot - #1211
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1211 +/- ##
=========================================
Coverage ? 52.43%
=========================================
Files ? 60
Lines ? 719
Branches ? 217
=========================================
Hits ? 377
Misses ? 335
Partials ? 7 Continue to review full report at Codecov.
|
nschonni
reviewed
Apr 20, 2021
Co-authored-by: Nick Schonning <nschonni@gmail.com>
Member
|
Would this auto update major versions? I don't think we should be doing that. |
Member
|
The type of bumping ranges can be configured, but it only creates PRs, so there isn't going to be any automagic major version changes pushed to the default branch |
benhalverson
approved these changes
Apr 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When I cloned this repo and installed the dependencies with
npm ci, I've got several security vulnerabilities reported, fortunately it will probably be fixed by #1201.But as I can see, currently you're always updating the dependencies manually, but I don't think it is great, even if
dependabotcould make daily noises, it would be worth it.Also as side note, I didn't updated every dependencies to latest version, but it would make sense to do it, so we could avoid having
dependabotliterraly spamming because nearly everything is out to date.