Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Upgrade storybook to 6.2 & attempt to use webpack 5 - #1178

Merged
benhalverson merged 6 commits into
nodejs:masterfrom
mikeesto:upgrade-storybook
Apr 17, 2021
Merged

Upgrade storybook to 6.2 & attempt to use webpack 5#1178
benhalverson merged 6 commits into
nodejs:masterfrom
mikeesto:upgrade-storybook

Conversation

@mikeesto

@mikeesto mikeesto commented Mar 26, 2021

Copy link
Copy Markdown
Member

Description

Upgrading storybook to 6.2 and configuring it to use webpack 5.

Remaining problems (updated):

Dark mode package:

99% done plugins webpack-hot-middlewarewebpack built preview 42d1ac8daa791e464dfa in 8349ms
ModuleNotFoundError: Module not found: Error: Package path ./commonjs is not exported from package /Users/michael/Code/nodejs.dev/node_modules/@smotaal.io/dark-mode-controller (see exports field in /Users/michael/Code/nodejs.dev/node_modules/@smotaal.io/dark-mode-controller/package.json)

Related Issues

See #1166 for more context

@mikeesto

mikeesto commented Apr 3, 2021

Copy link
Copy Markdown
Member Author

@benhalverson I have storybook working locally now with webpack 5 (sigh of relief). The only remaining issue is the dark mode package. I will wait until #1183 is merged and then open this PR for review.

@benhalverson

Copy link
Copy Markdown
Member

Hey @mikeesto #1183 has been merged feel free to update this PR when you are ready.

@mikeesto
mikeesto marked this pull request as ready for review April 13, 2021 01:46
@mikeesto

mikeesto commented Apr 13, 2021

Copy link
Copy Markdown
Member Author

Thanks @benhalverson . I think this should be good to go now. Would be great if you could pull down and try on your machine. Both storybook and Gatsby should work - with storybook now using webpack 5. Hopefully this unblocks your Gatsby upgrade

@benhalverson benhalverson added the create-preview Generate preview on staging.nodejs.dev label Apr 13, 2021
@github-actions github-actions Bot removed the create-preview Generate preview on staging.nodejs.dev label Apr 13, 2021
@github-actions

Copy link
Copy Markdown

Please find a preview at: https://staging.nodejs.dev/1178/

@benhalverson

Copy link
Copy Markdown
Member

Awesome I tried the deployed version here
https://staging.nodejs.dev/1178/storybook

@benhalverson

Copy link
Copy Markdown
Member

I’m not able to merge it. I see this message

This branch cannot be rebased due to conflicts
Rebasing the commits of this branch on top of the base branch cannot be performed automatically due to conflicts encountered while reapplying the individual commits from the head branch.

@mikeesto

Copy link
Copy Markdown
Member Author

Oh ok. I think it should be OK now? Let me know

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #1178 (f0ce3b9) into master (35ec9e0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1178   +/-   ##
=======================================
  Coverage   52.43%   52.43%           
=======================================
  Files          60       60           
  Lines         719      719           
  Branches      217      217           
=======================================
  Hits          377      377           
  Misses        335      335           
  Partials        7        7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35ec9e0...f0ce3b9. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants