feat: Added sidebar component to community page - #1174
Conversation
|
Please find a preview at: https://staging.nodejs.dev/1174/ |
mikeesto
left a comment
There was a problem hiding this comment.
Direct preview link: https://staging.nodejs.dev/1174/community/
Looks good! 👍
|
Clicking on section links redirects to learn section. Is that the supposed behavior? Also, each section redirects to a heading on the main community page. Can we try making different pages/MD files for each section? |
|
I dont think that was in scope for this ticket. This was just to make the sidebar component. I assumed those would be in a future issue. @benhalverson would have more insight though |
|
Yes thats right @lancemccluskey |
Codecov Report
@@ Coverage Diff @@
## master #1174 +/- ##
==========================================
- Coverage 51.35% 50.73% -0.62%
==========================================
Files 55 55
Lines 664 676 +12
Branches 192 197 +5
==========================================
+ Hits 341 343 +2
- Misses 316 326 +10
Partials 7 7
Continue to review full report at Codecov.
|
|
Can you look into why we are getting a conflict @lancemccluskey |
|
Yeah I'll take a look |
|
@benhalverson @designMoreWeb I added a few tests since I added a prop to the |
|
Ahhh okay that makes more sense now. Ill fix the conflicts |
|
Okay I following the directions for that issue in a stackoverflow I found here so hopefully its all good on your end. |
|
nope still the same message 😢 |
8b34271 to
b1c3bc5
Compare
|
Whoops I accidentally pulled the old commits into my branch instead of pushing the new stuff after rebasing. NOW everything should be fine lol. Do you think well ever switch to just using a clone of the repo instead of forks? I honestly dont understand the benefit of using forks |

Description
Added sidebar component in
pages/community.tsxbased on figma design here.Related Issues
Fixes #1145