Skip to content

Fix postmortem debugging metadata for V8 7.2 #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cjihrig wants to merge 20 commits into from
Closed

Fix postmortem debugging metadata for V8 7.2 #96

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
9687391
doc: update README for node-v8 repository
nodejs-ci Dec 21, 2018
ed27b49
deps: update V8 to 7.3.222
nodejs-ci Dec 21, 2018
afa2ecd
build: reset embedder string to "-node.0"
nodejs-ci Dec 21, 2018
54fed0a
src: update NODE_MODULE_VERSION to 70
nodejs-ci Dec 21, 2018
85c5b22
deps: sync V8 gypfiles with 7.2
targos Oct 10, 2018
e95a6e3
deps: bump minimum icu version to 63
ryzokuken Nov 8, 2018
ba1ad8a
src: fix merge conflicts while cherry-picking
targos Nov 17, 2018
5e72b56
test: remove apply calls over 65534 arg limit
psmarshall Nov 22, 2018
e80d9f7
test: update test-v8-stats
targos Nov 23, 2018
dd40b8f
deps: update V8 gypfiles
ryzokuken Nov 30, 2018
77ec35b
deps: update V8 gypfiles
targos Dec 6, 2018
5ea3407
deps: update v8.gyp and v8/cctest.gyp
ryzokuken Dec 8, 2018
2ce0ba6
deps: update v8.gyp, features.gypi, unittests.gyp
ryzokuken Dec 13, 2018
4509926
deps: update V8 gypfiles
targos Dec 16, 2018
4f8f29b
win: add v8_init to dependencies
bzoz Dec 11, 2018
49f3e96
deps: update v8.gyp
targos Dec 18, 2018
9dcf68d
deps: update v8.gyp
ryzokuken Dec 18, 2018
e60ef34
deps: update v8.gyp
targos Dec 20, 2018
f211dcd
deps: Update postmortem metadata generation script
cjihrig Dec 21, 2018
d550639
test: update postmortem metadata test for V8 7.2
cjihrig Dec 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
deps: sync V8 gypfiles with 7.2 
Co-authored-by: Ujjwal Sharma <usharma1998@gmail.com>
  • Loading branch information
@targos @ryzokuken @nodejs-ci
2 people authored and nodejs-ci committed Dec 21, 2018
commit 85c5b22c5ee2d9bd4ea768e7116c3d2dde217b86
3 changes: 3 additions & 0 deletions common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,9 @@
# Still WIP in V8 7.1
'v8_enable_pointer_compression': 'false',

# Explicitly set to false to copy V8's default
'v8_enable_31bit_smis_on_64bit_arch': 'false',

# New in V8 7.1
'v8_enable_embedded_builtins': 'true',

Expand Down
2 changes: 2 additions & 0 deletions deps/v8/gypfiles/d8.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@
'../src/async-hooks-wrapper.h',
'../src/d8-console.cc',
'../src/d8-console.h',
'../src/d8-platforms.cc',
'../src/d8-platforms.h',
'../src/d8.cc',
'../src/d8.h',
],
Expand Down
29 changes: 24 additions & 5 deletions deps/v8/gypfiles/features.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,21 @@

'v8_enable_gdbjit%': 0,

# Build-time flag for enabling nojit mode.
# TODO(v8:7777): Remove the build-time flag once the --jitless runtime flag
# does everything we need.
'v8_enable_jitless_mode%': 0,

# Enable code-generation-time checking of types in the CodeStubAssembler.
'v8_enable_verify_csa%': 0,

'v8_object_print%': 0,

# Lite mode disables a number of performance optimizations to reduce memory
# at the cost of performance.
# Sets --DV8_LITE_MODE.
'v8_enable_lite_mode%': 0,

'v8_enable_verify_heap%': 0,

'v8_trace_maps%': 0,
Expand Down Expand Up @@ -111,17 +122,17 @@

'v8_enable_pointer_compression%': 'false',

'v8_enable_embedded_builtins%': 'true',
'v8_enable_31bit_smis_on_64bit_arch%': 'false',

'v8_perf_prof_unwinding_info%': 0,
'v8_enable_embedded_builtins%': 'true',

'v8_enable_fast_mksnapshot%': 0,
},

'conditions': [
# V8's predicate inverted since we default to 'true' and set 'false' for unsupported cases.
# v8_use_snapshot && v8_current_cpu != "x86" && !is_aix && ( !is_win || is_clang)
['not (v8_use_snapshot=="true" and v8_target_arch !="ia32" and OS!="aix" and (OS!="win" or clang==1))', {
# !is_aix
['not (OS!="aix")', {
'variables': {
'v8_enable_embedded_builtins': 'false',
}
Expand All @@ -138,6 +149,9 @@
['v8_promise_internal_field_count!=0', {
'defines': ['V8_PROMISE_INTERNAL_FIELD_COUNT=<(v8_promise_internal_field_count)'],
}],
['v8_enable_lite_mode==1', {
'defines': ['V8_LITE_MODE',],
}],
['v8_enable_gdbjit==1', {
'defines': ['ENABLE_GDB_JIT_INTERFACE',],
}],
Expand Down Expand Up @@ -193,12 +207,17 @@
['v8_enable_pointer_compression=="true"', {
'defines': ['V8_COMPRESS_POINTERS',],
}],
['v8_enable_31bit_smis_on_64bit_arch=="true"', {
'defines': ['V8_31BIT_SMIS_ON_64BIT_ARCH',],
}],
['v8_enable_embedded_builtins=="true"', {
'defines': [
'V8_EMBEDDED_BUILTINS',
'V8_EMBEDDED_BYTECODE_HANDLERS',
],
}],
['v8_enable_jitless_mode==1', {
'defines': ['V8_JITLESS_MODE',],
}],
], # conditions
'defines': [
'V8_GYP_BUILD',
Expand Down
33 changes: 5 additions & 28 deletions deps/v8/gypfiles/inspector.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,11 @@
'<(SHARED_INTERMEDIATE_DIR)/include/inspector/Schema.h',
],

'inspector_injected_script_source': '../src/inspector/injected-script-source.js',
'inspector_generated_injected_script': '<(SHARED_INTERMEDIATE_DIR)/src/inspector/injected-script-source.h',

'inspector_all_sources': [
'../include/v8-inspector.h',
'../include/v8-inspector-protocol.h',
'../src/inspector/custom-preview.cc',
'../src/inspector/custom-preview.h',
'../src/inspector/injected-script.cc',
'../src/inspector/injected-script.h',
'../src/inspector/inspected-context.cc',
Expand All @@ -60,18 +59,12 @@
'../src/inspector/v8-debugger-agent-impl.h',
'../src/inspector/v8-debugger-script.cc',
'../src/inspector/v8-debugger-script.h',
'../src/inspector/v8-function-call.cc',
'../src/inspector/v8-function-call.h',
'../src/inspector/v8-heap-profiler-agent-impl.cc',
'../src/inspector/v8-heap-profiler-agent-impl.h',
'../src/inspector/v8-injected-script-host.cc',
'../src/inspector/v8-injected-script-host.h',
'../src/inspector/v8-inspector-impl.cc',
'../src/inspector/v8-inspector-impl.h',
'../src/inspector/v8-inspector-session-impl.cc',
'../src/inspector/v8-inspector-session-impl.h',
'../src/inspector/v8-internal-value-type.cc',
'../src/inspector/v8-internal-value-type.h',
'../src/inspector/v8-profiler-agent-impl.cc',
'../src/inspector/v8-profiler-agent-impl.h',
'../src/inspector/v8-regex.cc',
Expand All @@ -84,6 +77,8 @@
'../src/inspector/v8-stack-trace-impl.h',
'../src/inspector/v8-value-utils.cc',
'../src/inspector/v8-value-utils.h',
'../src/inspector/value-mirror.cc',
'../src/inspector/value-mirror.h',
'../src/inspector/wasm-translation.cc',
'../src/inspector/wasm-translation.h',
]
Expand All @@ -102,7 +97,7 @@
],
'action': [
'python',
'<(protocol_path)/CheckProtocolCompatibility.py',
'<(protocol_path)/check_protocol_compatibility.py',
'--stamp', '<@(_outputs)',
'<(inspector_path)/js_protocol.json',
],
Expand All @@ -128,23 +123,5 @@
],
'message': 'Generating inspector protocol sources from protocol json',
},
{
'action_name': 'convert_js_to_cpp_char_array',
'inputs': [
'<(inspector_path)/build/xxd.py',
'<(inspector_injected_script_source)',
],
'outputs': [
'<(inspector_generated_injected_script)',
],
'process_outputs_as_sources': 1,
'action': [
'python',
'<(inspector_path)/build/xxd.py',
'InjectedScriptSource_js',
'<(inspector_path)/injected-script-source.js',
'<@(_outputs)'
],
},
],
}
Loading