Skip to content
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
d91a42d
doc: update README for node-v8 repository
nodejs-ci Mar 3, 2020
a295ca6
deps: update V8 to 8.2.237
nodejs-ci Mar 3, 2020
6aae14a
build: reset embedder string to "-node.0"
nodejs-ci Mar 3, 2020
b046a94
deps: V8: un-cherry-pick bd019bd
refack Mar 27, 2019
b16cfdd
deps: V8: silence irrelevant warnings
targos Mar 27, 2019
61cc0cc
deps: patch V8 to run on older XCode versions
ryzokuken Sep 14, 2019
e550019
deps: update V8's postmortem script
cjihrig Sep 27, 2019
1ff812b
deps: update V8's postmortem script
cjihrig Oct 15, 2019
3cb0f84
deps: V8: patch register-arm64.h
refack May 22, 2019
4df4620
deps: V8: forward declaration of `Rtl*FunctionTable`
refack May 22, 2019
b01bfde
deps: make v8.h compatible with VS2015
joaocgreis Nov 1, 2019
ecb8cea
build: enable backtrace when V8 is built for PPC and S390x
targos Oct 29, 2019
c9d3538
tools: update V8 gypfiles for V8 8.0
targos Oct 18, 2019
b308552
src: stop overriding deprecated V8 methods
backes Dec 2, 2019
ec140df
Revert "assert: fix line number calculation after V8 upgrade"
targos Dec 6, 2019
b5c1c8e
tools: update inspector.gypi
ryzokuken Dec 6, 2019
4867f9a
tools: update v8.gyp
targos Dec 7, 2019
a0cc68a
try to fix include in zlib.gyp
targos Dec 7, 2019
885a556
deps: update V8's postmortem script
cjihrig Dec 8, 2019
3def38a
test: update test-postmortem-metadata.js
cjihrig Dec 8, 2019
5152104
src: update v8abbr.h for V8 update
cjihrig Dec 8, 2019
3c1f76a
tools: try to fix zlib for cross-compilation
targos Dec 9, 2019
085ad05
tools: update v8.gyp
targos Dec 11, 2019
91f574a
tools: update gypfiles
targos Dec 16, 2019
db9ff5b
tools: update features.gypi
targos Dec 17, 2019
b2cb8f2
tools: update v8.gyp
ryzokuken Dec 19, 2019
1e21691
tools: update v8.gyp
ryzokuken Dec 30, 2019
7b5322c
fixup! fix typo from commit 3078bcdb131
bnoordhuis Jan 3, 2020
fa2420b
build: simplify v8's vendored zlib build
bnoordhuis Jan 3, 2020
3d7ad5d
deps: bump minimum icu version to 65
targos Jan 6, 2020
231b38b
tools: update v8.gyp
targos Jan 13, 2020
e846985
src: remove use of deprecated Symbol::Name()
cjihrig Dec 14, 2019
b63baa9
tools: update v8.gyp
richardlau Jan 17, 2020
6e29204
tools: update v8 gypfiles
targos Jan 17, 2020
df875ac
tools: update v8.gyp
targos Jan 27, 2020
aa340c4
Update tests for larger Buffers
jakobkummerow Jan 20, 2020
d4cdbb5
Remove checks for deserializing wasm
backes Jan 22, 2020
a026b86
tools: update v8.gyp
targos Feb 2, 2020
9074bf7
tools: update V8 gypfiles
targos Feb 11, 2020
cc83a48
Avoid calling deprecated method
backes Feb 3, 2020
061db16
tools: update v8 gypfiles
targos Feb 14, 2020
c8488bc
tools: update v8 gypfiles
gengjiawen Feb 25, 2020
82b025f
tools: update v8 gypfiles
targos Feb 27, 2020
dc60708
Remove deprecated wasm type check
backes Feb 6, 2020
767a1ba
Remove test
backes Feb 6, 2020
57b9747
Move back deprecated util method, and use REPLACEME
backes Feb 7, 2020
2ab89a2
Rename FinalizationGroup to FinalizationRegistry
syg Feb 24, 2020
535dc9b
v8: include right headers in torque output
gengjiawen Feb 27, 2020
d1a1e20
vm: migrate measureMemory to new v8 api
gengjiawen Mar 4, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
deps: make v8.h compatible with VS2015
There is a bug in the most recent version of VS2015 that affects v8.h
and therefore prevents compilation of addons.

Refs: https://stackoverflow.com/q/38378693

PR-URL: nodejs/node#30020
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
  • Loading branch information
joaocgreis authored and nodejs-ci committed Mar 3, 2020
commit b01bfde3d939733544a00bc0291fd0154bc54e72
2 changes: 1 addition & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.7',
'v8_embedder_string': '-node.8',

##### V8 defaults for Node.js #####

Expand Down
2 changes: 2 additions & 0 deletions deps/v8/include/v8.h
Original file line number Diff line number Diff line change
Expand Up @@ -1760,9 +1760,11 @@ class V8_EXPORT ScriptCompiler {
public:
enum Encoding { ONE_BYTE, TWO_BYTE, UTF8 };

#if defined(_MSC_VER) && _MSC_VER >= 1910 /* Disable on VS2015 */
V8_DEPRECATE_SOON(
"This class takes ownership of source_stream, so use the constructor "
"taking a unique_ptr to make these semantics clearer")
#endif
StreamedSource(ExternalSourceStream* source_stream, Encoding encoding);
StreamedSource(std::unique_ptr<ExternalSourceStream> source_stream,
Encoding encoding);
Expand Down