Skip to content
This repository was archived by the owner on Jun 18, 2021. It is now read-only.

build: disable compiler inlining on z/OS #146

Merged
richardlau merged 1 commit into from
Jul 3, 2020
Merged

build: disable compiler inlining on z/OS #146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
build: disable compiler inlining on z/OS 
In Node v14 on z/OS, test `test-exception.js` fails due to a
compiler issue with inlining.

This PR works around it by disabling compiler inlining.

I confirmed that, with this change, `npm test` continues to pass in
Node v8.17.0 (which uses D190508 compiler version), as well as in
Node v12.16.1 (which uses D191122 as in v14).

Once the new Wyvern on z compiler is available for use in Node v14,
we'll revisit and undo this change if Woz resolves the issue.
  • Loading branch information
@gabylb
gabylb committed Jul 2, 2020
commit 88d64bea48c488fe3e7d195c37167dc62a9a8f18
4 changes: 2 additions & 2 deletions binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
"dll_files": [ "dbghelp.dll", "Netapi32.dll", "PsApi.dll", "Ws2_32.dll" ],
}],
["OS=='zos'", {
"cflags!": [ "-O2", "-O3" ],
"cflags": [ "-qascii" ],
"cflags!": [ "-O2", "-O3", "-qINLINE=::150:100000" ],
"cflags": [ "-qascii", "-qnoinline" ],
}],
],
"defines": [
Expand Down