Add test for errors thrown from n-api addon

nodejs · richardlau · Jun 26, 2019 · Jun 26, 2019 · Jun 26, 2019 · Jun 26, 2019
commit bb468b50ca8d0963e162e38700e7aeb515521f11
diff --git a/.gitignore b/.gitignore
@@ -36,6 +36,7 @@
 # Build directories
 /build/
 /node_modules/
+/test/*/build/
 
 # Package files
 NodeReport*.txt

diff --git a/test/napi_throw/binding.gyp b/test/napi_throw/binding.gyp
@@ -0,0 +1,10 @@
+{
+  "targets": [
+    {
+      "target_name": "test_napi_throw",
+      "sources": [
+        "test_napi_throw.c"
+      ]
+    }
+  ]
+}
diff --git a/test/napi_throw/package-lock.json b/test/napi_throw/package-lock.json
diff --git a/test/napi_throw/package.json b/test/napi_throw/package.json
@@ -0,0 +1,13 @@
+{
+  "name": "test_napi_throw",
+  "version": "1.0.0",
+  "description": "Throw an error.",
+  "scripts": {
+    "test": "echo \"Error: no test specified\" && exit 1",
+    "install": "node-gyp rebuild"
+  },
+  "author": "",
+  "license": "ISC",
+  "repository": "https://github.com/nodejs/node-report",
+  "gypfile": true
+}
diff --git a/test/napi_throw/test_napi_throw.c b/test/napi_throw/test_napi_throw.c
@@ -0,0 +1,28 @@
+#include <assert.h>
+
+#include <node_api.h>
+
+napi_value ThrowError(napi_env env, napi_callback_info info) {
+  napi_throw_error(env, NULL, "an error occurred"); 
+  return NULL;
+}
+
+static napi_value Init(napi_env env, napi_value exports) {
+  napi_value result;
+  assert(napi_create_object(env, &result) == napi_ok);
+  napi_value exported_function;
+  assert(napi_create_function(env,
+                              "throwError",
+                              NAPI_AUTO_LENGTH,
+                              ThrowError,
+                              NULL,
+                              &exported_function) == napi_ok);
+
+  assert(napi_set_named_property(env,
+                                 result,
+                                 "throwError",
+                                 exported_function) == napi_ok);
+  return result;
+}
+
+NAPI_MODULE(NODE_GYP_MODULE_NAME, Init)
diff --git a/test/test-napi-throw.js b/test/test-napi-throw.js
@@ -0,0 +1,22 @@
+'use strict';
+
+const tap = require('tap');
+
+// Build addon that throws an error
+const cp = require('child_process');
+const path = require('path');
+const build = cp.spawnSync('npm', [ 'install', '.' ],
+                           { cwd: path.join(__dirname, 'napi_throw'),
+                           encoding: 'utf8' });
+tap.equal(build.stderr, '', 'No errors building addon');
+tap.equal(build.signal, null, 'Failed to build addon');
+tap.equal(build.status, 0, 'Failed to build addon');
+
+// Test catching the error does not trigger an UncaughtException report
+const common = require('./common.js');
+const report = require('../');
+const obj = require('./napi_throw/build/Release/test_napi_throw.node');
+tap.throws(obj.throwError);
+
+const reports = common.findReports(process.pid);
+tap.equals(reports, [], 'No reports should be generated');