Skip to content
This repository was archived by the owner on Feb 1, 2022. It is now read-only.

Update test suite to pass on latest nightly #36

Merged
hybrist merged 4 commits into from
Apr 3, 2017
Merged

Update test suite to pass on latest nightly #36

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
41148d7
test: Remove outdated test
Mar 15, 2017
2c224c5
test: Accept any kind of "break"
Apr 3, 2017
22bf349
test: Adjust for v8 5.7
Apr 3, 2017
6ce8c16
test: Revert to old assertions
Apr 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: Remove outdated test
  • Loading branch information
Jan Krems committed Apr 3, 2017
commit 41148d74a2d563eea3b7ad5463622b6b9fd4c46e
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
},
"scripts": {
"pretest": "eslint --rulesdir=tools/eslint-rules lib test",
"test": "tap \"test/**/*.test.js\"",
"test": "tap test",
Copy link
Copy Markdown

@dbushong dbushong Apr 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it ok that this might load non-test js files? (ones intended to be require()ed from elsewhere?)

Copy link
Copy Markdown
Collaborator Author

@hybrist hybrist Apr 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now there's only one of those (test/cli/start-cli.js) which is a bit annoying. In future, I'd rather move those helpers into a sibling directory (test-helpers/) than risk the inconsistent glob behavior.

"posttest": "nlm verify"
},
"nlm": {
Expand Down
5 changes: 5 additions & 0 deletions test/cli/start-cli.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
'use strict';
const spawn = require('child_process').spawn;

// This allows us to keep the helper inside of `test/` without tap warning
// about "pending" test files.
const tap = require('tap');
tap.test('startCLI', (t) => t.end());

const CLI =
process.env.USE_EMBEDDED_NODE_INSPECT === '1' ?
'inspect' :
Expand Down
9 changes: 0 additions & 9 deletions test/node-inspect.test.js
View file
Open in desktop

This file was deleted.