Skip to content

Ensure Consistent Order of build_files in WriteAutoRegenerationRule #3062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ben-zalekta-lmnd wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Ensure Consistent Order of build_files in WriteAutoRegenerationRule #3062

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: Ensure Consistent Order of build_files in WriteAutoRegenerationRule 
Wrapped the build_files set in the sorted() function before it is processed in WriteAutoRegenerationRule. This ensures that the order of files is consistent across all runs, preventing issues in CI environments that rely on file hash comparisons.
  • Loading branch information
@ben-zalekta-lmnd
ben-zalekta-lmnd committed Aug 19, 2024
commit 85166ffc79158fb259154c948ddd65437c2cbb0a
2 changes: 1 addition & 1 deletion gyp/pylib/gyp/generator/make.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2383,7 +2383,7 @@ def WriteAutoRegenerationRule(params, root_makefile, makefile_name, build_files)
% {
"makefile_name": makefile_name,
"deps": replace_sep(
" ".join(SourceifyAndQuoteSpaces(bf) for bf in build_files)
" ".join(SourceifyAndQuoteSpaces(bf) for bf in sorted(build_files))
),
"cmd": replace_sep(gyp.common.EncodePOSIXShellList(
[gyp_binary, "-fmake"] + gyp.RegenerateFlags(options) + build_files_args
Expand Down