Skip to content
This repository was archived by the owner on Jul 31, 2018. It is now read-only.

uv_link_t: initial #32

Closed
indutny wants to merge 7 commits into from
Closed

uv_link_t: initial #32

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
167660b
uv_link_t: initial
indutny Jun 3, 2016
561ba80
fixes
indutny Jun 3, 2016
50199ab
add note about observability
indutny Jun 3, 2016
d4ac1d5
fixes
indutny Jun 3, 2016
2dd1e26
fix typo
indutny Jun 4, 2016
8080c8f
fix
indutny Jun 6, 2016
6c683d0
add description
indutny Jun 16, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix
  • Loading branch information
@indutny
indutny committed Jun 6, 2016
commit 8080c8fba0b6ddd45790d54b4be26ba727269dd7
5 changes: 3 additions & 2 deletions xxx-uv_link_t.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ classes that inherit from `StreamBase`.
## 2. Current state of C++ Streams in Node

The fast HTTP and TLS protocol implementation in Node core depends on so called
`StreamBase` C++ class. This class is an analog of JavaScript streams in C++.
`StreamBase` C++ class and auxiliary `StreamReq` and `StreamResources` classes.
This class is an analog of JavaScript streams in C++.
The main ideas behind `StreamBase` are to:
Copy link
Copy Markdown
Contributor

@trevnorris trevnorris Jun 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean you'll be removing associated classes like StreamReq and StreamResource?

Copy link
Copy Markdown
Member Author

@indutny indutny Jun 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

Copy link
Copy Markdown
Member

@rvagg rvagg Jun 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be noted in the text

Copy link
Copy Markdown
Member Author

@indutny indutny Jun 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack.


1. Avoid unnecessary memory allocations by reading data directly into buffer
Expand All @@ -34,7 +35,7 @@ From [`uv_link_t`][0] readme:

`uv_link_t` aims to solve complexity problem that quickly escalates once
using multiple layers of protocols in [libuv][1] by providing a way to
implement protocols separately and chain them together in easy and
implement protocols separately and chain them together in an easy and
high-performant way using very narrow interfaces.

Given that [`uv_link_t`][0] depends only on [libuv][1], it is very easy to
Expand Down