Skip to content

feat(ncu-ci): parse comments to find a safe commit #920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
aduh95 wants to merge 4 commits into
base: main
Choose a base branch
from
+82 −18
Draft

feat(ncu-ci): parse comments to find a safe commit #920

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5d1a760
feat(ncu-ci): parse comments to find a safe commit
aduh95 Apr 5, 2025
51ce389
fix tests
aduh95 Apr 6, 2025
37696bd
add tests
aduh95 Apr 6, 2025
733bd44
cleaner teardown
aduh95 Apr 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
cleaner teardown
  • Loading branch information
@aduh95
aduh95 committed Apr 6, 2025
commit 733bd44a743adcce14bc17a789e297a1907fed99
9 changes: 8 additions & 1 deletion test/unit/ci_start.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ describe('Jenkins', () => {
const dummySHA = '51ce389dc1d539216d30bba0986a8c270801d65f';

before(() => {
sinon.stub(FormData.prototype, 'append').callsFake(function(key, value) {
const stubbed = sinon.stub(FormData.prototype, 'append').callsFake(function(key, value) {
assert.strictEqual(key, 'json');
const { parameter } = JSON.parse(value);
const expectedParameters = {
Expand All @@ -45,6 +45,8 @@ describe('Jenkins', () => {

return Reflect.apply(FormData.prototype.append.wrappedMethod, this, arguments);
});

return () => stubbed.restore();
});

it('should fail if starting node-pull-request throws', async() => {
Expand Down Expand Up @@ -121,12 +123,17 @@ describe('Jenkins', () => {
before(() => {
sinon.replace(PRData.prototype, 'getReviews', function() {});
sinon.replace(PRData.prototype, 'getCommits', function() {});
return () => {
PRData.prototype.getReviews.restore();
PRData.prototype.getCommits.restore();
};
});
afterEach(() => {
PRData.prototype.getCollaborators.restore();
PRData.prototype.getComments.restore();
PRChecker.prototype.getApprovedTipOfHead.restore();
});

for (const { headIsApproved = false, collaborators = [], comments = [], expected } of [{
headIsApproved: true,
expected: true,
Expand Down
Loading