Skip to content

fix: update detection of changelog links (take 2) #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
richardlau merged 1 commit into from
Oct 26, 2021
Merged

fix: update detection of changelog links (take 2) #575

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: update detection of changelog links (take 2) 
Underscores in the links to the changelogs are escaped for markdown
links but not escaped for HTML links.
  • Loading branch information
@richardlau
richardlau committed Oct 26, 2021
commit 0482bb80b017296c8603e85e4ff41ad83eddb261
8 changes: 5 additions & 3 deletions lib/prepare_release.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,16 +332,18 @@ class ReleasePreparation {
const arr = data.split('\n');

const major = versionComponents.major;
const hrefLink = `doc/changelogs/CHANGELOG\\_V${major}.md`;
const hrefLink = `doc/changelogs/CHANGELOG_V${major}.md`;
const escapedHrefLink = hrefLink.replace(/_/g, '\\_');
const newRefLink = `<a href="${hrefLink}#${newVersion}">${newVersion}</a>`;
const lastRefLink = `<a href="${hrefLink}#${lastRef}">${lastRef}</a>`;

for (let idx = 0; idx < arr.length; idx++) {
if (isLTSTransition) {
if (arr[idx].includes(hrefLink)) {
if (arr[idx].includes(escapedHrefLink)) {
arr[idx] = arr[idx].replace('**Current**', '**Long Term Support**');
} else if (arr[idx].includes(hrefLink)) {
const eolDate = getEOLDate(date);
const eol = eolDate.toISOString().split('-').slice(0, 2).join('-');
arr[idx] = arr[idx].replace('**Current**', '**Long Term Support**');
arr[idx] = arr[idx].replace('"Current"', `"LTS Until ${eol}"`);
arr[idx] = arr[idx].replace('<sup>Current</sup>', '<sup>LTS</sup>');
} else if (arr[idx].includes('**Long Term Support**')) {
Expand Down