Skip to content

fix: update detection of changelog links #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
richardlau merged 1 commit into from
Oct 25, 2021
Merged

fix: update detection of changelog links #573

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: update detection of changelog links 
The Node.js `CHANGELOG.md` file was changed so that `_` characters in
links are now escaped.

Refs: nodejs/node#40322
  • Loading branch information
@richardlau
richardlau committed Oct 20, 2021
commit 3bd7dfd6fa680d2cf511e585fea2e66e1f6d4dea
3 changes: 2 additions & 1 deletion lib/prepare_release.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,8 @@ class ReleasePreparation {
const data = await fs.readFile(mainChangelogPath, 'utf8');
const arr = data.split('\n');

const hrefLink = `doc/changelogs/CHANGELOG_V${versionComponents.major}.md`;
const major = versionComponents.major;
const hrefLink = `doc/changelogs/CHANGELOG\\_V${major}.md`;
const newRefLink = `<a href="${hrefLink}#${newVersion}">${newVersion}</a>`;
const lastRefLink = `<a href="${hrefLink}#${lastRef}">${lastRef}</a>`;

Expand Down