Skip to content

Small refactor and allow to fixup everythindg into first commit with --fixupAll #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joyeecheung merged 2 commits into from
Aug 27, 2020
Merged

Small refactor and allow to fixup everythindg into first commit with --fixupAll #490

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5b356b
refactor: use options object in LandingSession
lundibundi Aug 22, 2020
0f5f069
feat: allow to fixup everything into first commit with fixupAll
lundibundi Aug 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
refactor: use options object in LandingSession
  • Loading branch information
@lundibundi
lundibundi committed Aug 22, 2020
commit f5b356b578e42ed0dfeb73e0359a21184a85034d
3 changes: 1 addition & 2 deletions components/git/land.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,8 +175,7 @@ async function main(state, argv, cli, req, dir) {
cli.log('run `git node land --abort` before starting a new session');
return;
}
session = new LandingSession(cli, req, dir, argv.prid, argv.backport,
argv.lint, argv.autorebase);
session = new LandingSession(cli, req, dir, argv);
const metadata = await getMetadata(session.argv, argv.skipRefs, cli);
if (argv.backport) {
const split = metadata.metadata.split('\n')[0];
Expand Down
2 changes: 1 addition & 1 deletion lib/landing_session.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ const LINT_RESULTS = {
};

class LandingSession extends Session {
constructor(cli, req, dir, prid, backport, lint, autorebase) {
constructor(cli, req, dir, { prid, backport, lint, autorebase } = {}) {
super(cli, dir, prid);
this.req = req;
this.backport = backport;
Expand Down