Skip to content

fix: allow opt-out of Fixes/Refs metadata #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codebytere merged 2 commits into from
Aug 15, 2020
Merged

fix: allow opt-out of Fixes/Refs metadata #474

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c429b45
fix: allow opt-out of Fixes/Refs metadata
codebytere Aug 12, 2020
1f3aa86
Add metadata gen test
codebytere Aug 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add metadata gen test
  • Loading branch information
@codebytere
codebytere committed Aug 15, 2020
commit 1f3aa8696b73c2c75d39e49aab8b3b957c623ab5
12 changes: 12 additions & 0 deletions test/unit/metadata_gen.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,12 @@ Backport-PR-URL: https://github.com/nodejs/node/pull/30072
Fixes: https://github.com/nodejs/build/issues/1961
Refs: https://github.com/nodejs/node/commit/53ca0b9ae145c430842bf78e553e3b6cbd2823aa#commitcomment-35494896
`;
const skipRefsExpected = `PR-URL: https://github.com/nodejs/node/pull/16438
Reviewed-By: Foo User <foo@example.com>
Reviewed-By: Quux User <quux@example.com>
Reviewed-By: Baz User <baz@example.com>
Reviewed-By: Bar User <bar@example.com>
`;

describe('MetadataGenerator', () => {
it('should generate metadata properly', () => {
Expand All @@ -68,4 +74,10 @@ describe('MetadataGenerator', () => {
const backportResults = new MetadataGenerator(backportData).getMetadata();
assert.strictEqual(backportExpected, backportResults);
});

it('should skip adding Fixes/Refs metadata when --skipRefs is passed', () => {
const data = { skipRefs: true, ...crossData };
const backportResults = new MetadataGenerator(data).getMetadata();
assert.strictEqual(skipRefsExpected, backportResults);
});
});