Skip to content

feat: handle unmarked DEP0XXX tags during landing and release #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codebytere merged 4 commits into from
Jun 7, 2020
Merged

feat: handle unmarked DEP0XXX tags during landing and release #420

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d97c294
feat: update DEP0XXX tags during release prep
codebytere May 20, 2020
53a4c31
refactor: check deps during landing
codebytere May 20, 2020
f8cbdc2
Only auto-assign multiple DEPOXXX when landing
codebytere Jun 3, 2020
a3c6eb7
Staging......also important
codebytere Jun 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Staging......also important
  • Loading branch information
@codebytere
codebytere committed Jun 4, 2020
commit a3c6eb7b45f668ac5e4b5465cf4fb8f492bc6be1
6 changes: 4 additions & 2 deletions lib/landing_session.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,12 @@ class LandingSession extends Session {
const unmarkedDepCount = unmarkedDeprecations.length;
if (unmarkedDepCount > 0) {
cli.startSpinner('Assigning deprecation numbers to DEPOXXX items');
await updateDeprecations(unmarkedDeprecations);

// Amend the last commit with the updated deprecation items.
// Update items then stage files and amend the last commit.
await updateDeprecations(unmarkedDeprecations);
await runAsync('git', ['add', 'doc', 'lib', 'src', 'test']);
await runAsync('git', ['commit', '--amend', '--no-edit']);
Comment thread
codebytere marked this conversation as resolved.

cli.stopSpinner(`Updated ${unmarkedDepCount} DEPOXXX items in codebase`);
}

Expand Down