Skip to content

git-node: add release promotion step #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
codebytere wants to merge 12 commits into from
Closed

git-node: add release promotion step #402

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
9ee6605
git-node: add release promotion step
codebytere Apr 9, 2020
15c4cb0
Move newVersion to named arg
codebytere Apr 9, 2020
0ec3327
Split out promotion verification steps
codebytere Apr 9, 2020
a1c3ef1
Fix verification spinners
codebytere Apr 14, 2020
61dbeb7
Verify ncurc is set up
codebytere Apr 14, 2020
ea29f87
Properly trim getCommitSha result
codebytere Apr 14, 2020
c0db1ce
Address some feedback
codebytere May 4, 2020
7d23d70
Ensure synced with upstream/master
codebytere May 4, 2020
692c6b7
fix: run release script asynchronously
codebytere May 4, 2020
c1ab158
Run secureTagRelease() asynchronously
codebytere May 20, 2020
ddfe6ef
Run cherry-pick asynchronously
codebytere May 26, 2020
3377b44
Remove unneccessary quotes
codebytere May 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: run release script asynchronously
  • Loading branch information
@codebytere
codebytere committed May 20, 2020
commit 692c6b725246319733e5433ad044f4fc06862fb8
12 changes: 6 additions & 6 deletions lib/promote_release.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ const { promises: fs } = require('fs');
const semver = require('semver');

const { getMergedConfig } = require('./config');
const { runSync } = require('./run');
const { runSync, runAsync } = require('./run');
const auth = require('./auth');
const PRData = require('./pr_data');
const PRChecker = require('./pr_checker');
Expand Down Expand Up @@ -101,7 +101,7 @@ class ReleasePromotion {

// Merge vX.Y.Z-proposal into vX.x.
cli.startSpinner('Merging proposal branch');
await this.mergeProposalBranch();
this.mergeProposalBranch();
cli.stopSpinner('Merged proposal branch');

// Cherry pick release commit to master.
Expand Down Expand Up @@ -151,7 +151,7 @@ class ReleasePromotion {
const keyPath = await cli.prompt(
`Please enter the path to your ssh key (Default ${defaultKeyPath}): `,
{ questionType: 'input', defaultAnswer: defaultKeyPath });
this.promoteAndSignRelease(keyPath);
await this.promoteAndSignRelease(keyPath);

cli.separator();
cli.ok(`Release promotion for ${version} complete.\n`);
Expand Down Expand Up @@ -292,7 +292,7 @@ class ReleasePromotion {
]);
}

async mergeProposalBranch() {
mergeProposalBranch() {
const { stagingBranch, versionComponents, version } = this;

const releaseBranch = `v${versionComponents.major}.x`;
Expand All @@ -313,8 +313,8 @@ class ReleasePromotion {
return runSync('git', ['push', 'upstream', tagVersion]);
}

promoteAndSignRelease(keyPath) {
return runSync('./tools/release.sh', ['-i', keyPath]);
async promoteAndSignRelease(keyPath) {
await runAsync('./tools/release.sh', ['-i', keyPath]);
}

cherryPickToMaster() {
Expand Down