Skip to content

git-node: add git-node-release #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codebytere merged 16 commits into from
Apr 3, 2020
Merged

git-node: add git-node-release #388

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
4e6da65
git-node: add git-node-release
codebytere Feb 26, 2020
8a3bb80
feat: verify Releaser status
codebytere Mar 1, 2020
7318bab
Address review feedback
codebytere Mar 1, 2020
cfda042
Add notables to commmit msg body
codebytere Mar 1, 2020
f09a47c
refactor: address review comments
codebytere Mar 2, 2020
09d5c0b
fix: update for new cli.prompt
codebytere Mar 2, 2020
ee51222
Create proposal branch automatically
codebytere Mar 3, 2020
f9c8cbb
Address some feedback from @mylesborins
codebytere Mar 11, 2020
7e8f11a
Automatically calculate version based on commits
codebytere Mar 11, 2020
15bbc23
fix: create release commit w/o markdown
codebytere Mar 11, 2020
6cda82a
fix: use changelog to determine new version
codebytere Mar 11, 2020
c0693d7
fix: use Current branch instead of master for LTS comparison
codebytere Mar 12, 2020
66d6a06
Move initial branchDiff to prepare
codebytere Mar 17, 2020
079b860
Remove push/pr automation
codebytere Mar 19, 2020
30dbaa8
Fix accidental splice removal
codebytere Mar 24, 2020
be4c952
Add changelog-maker dep per @rvagg feedback
codebytere Mar 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove push/pr automation
  • Loading branch information
@codebytere
codebytere committed Mar 19, 2020
commit 079b860e5ddf37cca1e2fba351becce3f38dc418
38 changes: 3 additions & 35 deletions lib/prepare_release.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,28 +149,12 @@ class ReleasePreparation {
{ defaultAnswer: false });
}

// Push branch to upstream.
const shouldPushBranch = await cli.prompt(
'Push branch to upstream?');
if (!shouldPushBranch) {
cli.warn(`Aborting \`git node release\` for version ${newVersion}`,
{ defaultAnswer: false });
return;
}
this.pushBranch();

// Open pull request against the release branch.
const shouldOpenPR = await cli.prompt(
`Open pull request against ${versionComponents.major}.x?`,
{ defaultAnswer: false });
if (shouldOpenPR) {
this.openPullRequest();
}

cli.separator();
cli.ok(`Release preparation for ${newVersion} complete.\n`);
cli.info(
'Please proceed to Jenkins and begin the following CI jobs:\n' +
'To finish the release proposal, run: \n' +
` $ git push ${`v${semver.major(newVersion)}.x-staging`}\n` +
'Finally, proceed to Jenkins and begin the following CI jobs:\n' +
' * https://ci.nodejs.org/job/node-test-pull-request/\n' +
' * https://ci.nodejs.org/job/citgm-smoker/');
cli.info(
Expand Down Expand Up @@ -240,22 +224,6 @@ class ReleasePreparation {
]).trim();
}

pushBranch() {
const { newVersion, upstream } = this;
const proposalBranch = `v${newVersion}-proposal`;

runSync('git', ['push', upstream, proposalBranch]).trim();
}

openPullRequest() {
const { newVersion, versionComponents } = this;
const proposalBranch = `v${newVersion}-proposal`;
const releaseBranch = `v${versionComponents.major}.x`;

runSync('open',
[`https://github.com/nodejs/node/compare/${releaseBranch}...${proposalBranch}?expand=1`]);
}

async updateREPLACEMEs() {
const { newVersion } = this;

Expand Down