feat: port test_instance_data to CTS - #66
Draft
bavulapati wants to merge 2 commits into
Draft
Conversation
bavulapati
force-pushed
the
feat/port-test-instance-data
branch
from
July 31, 2026 11:00
c9bb8c3 to
4075e18
Compare
bavulapati
marked this pull request as draft
July 31, 2026 11:01
bavulapati
force-pushed
the
feat/port-test-instance-data
branch
from
July 31, 2026 11:08
4075e18 to
402dbf6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports
test/js-native-api/test_instance_data.test.js- in-process:increment()returns 42, and a finalizer reaching instance data to call back into JS.testInstanceDataTeardown.js- thenapi_set_instance_datadelete hook only runs at environment teardown, so it spawns a child and checks thedeleting addon dataline on its stdout.testInstanceDataWorker.js- upstream's worker variant: the same in a secondary environment, covering per-environment instance data and teardown of that environment alone.Stacked on #67, which adds the
{ worker: true }option the worker test needs - review that one first. Draft until it lands.