Skip to content

src: return Maybe<> on pending exception when cpp exception disabled #927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
legendecas merged 12 commits into from
Aug 3, 2021
Merged

src: return Maybe<> on pending exception when cpp exception disabled #927

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
451f27f
src: return Maybe<> on pending exception when cpp exception disabled
legendecas Mar 9, 2021
0f95980
fixup! remove the newly added napi_pending_exception checks
legendecas Jun 3, 2021
676798c
fixup! FunctionReference::New return type
legendecas Jun 9, 2021
6d16dda
fixup!
legendecas Jun 10, 2021
c1385ba
fixup! doc: test docs
legendecas Jun 10, 2021
b946305
fixup! linter complaints
legendecas Jun 10, 2021
fec9561
fixup! review suggestions
legendecas Jun 16, 2021
6012787
Merge branch 'main' into maybe
legendecas Jun 17, 2021
baf6ab8
fixup! remove unnecessary MaybeUnwrapOr
legendecas Jun 18, 2021
43e14e5
fixup! apply review suggestions
legendecas Jul 14, 2021
b16a549
Merge remote-tracking branch 'upstream/main' into maybe
legendecas Jul 14, 2021
68facc7
fixup! update Symbol::For
legendecas Jul 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! FunctionReference::New return type
  • Loading branch information
@legendecas
legendecas committed Jun 9, 2021
commit 676798c3facf4417263fbfde134269bae83f0c60
5 changes: 3 additions & 2 deletions test/functionreference.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
#include "napi.h"
#include "test_helper.h"

using namespace Napi;

Expand All @@ -8,15 +9,15 @@ Value Call(const CallbackInfo& info) {
FunctionReference ref;
ref.Reset(info[0].As<Function>());

return ref.Call({});
return MaybeUnwrapOr(ref.Call({}));
Comment thread
legendecas marked this conversation as resolved.
Outdated
}

Value Construct(const CallbackInfo& info) {
HandleScope scope(info.Env());
FunctionReference ref;
ref.Reset(info[0].As<Function>());

return ref.New({});
return MaybeUnwrapOr(ref.New({}));
}
} // namespace

Expand Down