Skip to content

Add Object missing tests #923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JoseExposito wants to merge 10 commits into from
Closed

Add Object missing tests #923

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
65d259d
Test that Object::GetPropertyNames does not return properties whose k…
JoseExposito Mar 5, 2021
47fcf4a
Test that Object::Get returns undefined if the key does not exist
JoseExposito Mar 5, 2021
cdd5c9f
Add test for Object::InstanceOf
JoseExposito Mar 5, 2021
785c38f
Add test for Object::Object empty constructor
JoseExposito Mar 5, 2021
cc65d0a
Add test for Object::operator[]
JoseExposito Mar 5, 2021
896a746
Fix linter issues
JoseExposito Mar 11, 2021
4abe5b8
Use IsEmpty to test Object constructor
JoseExposito Mar 13, 2021
8e2ee12
Test that Object::operator[] overrides object keys by index
JoseExposito Mar 13, 2021
61a0c76
Test that it is possible to create a JavaScript object from another J…
JoseExposito Mar 13, 2021
ca18766
Merge branch 'main' into object-tests
JoseExposito Mar 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add test for Object::InstanceOf
  • Loading branch information
@JoseExposito
JoseExposito committed Mar 5, 2021
commit cdd5c9f7495cb7e5713ca62f525cc5cb9810ba6b
8 changes: 8 additions & 0 deletions test/object/object.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,12 @@ Value CreateObjectUsingMagic(const CallbackInfo& info) {
return obj;
}

Value InstanceOf(const CallbackInfo& info) {
Object obj = info[0].As<Object>();
Function constructor = info[1].As<Function>();
return Boolean::New(info.Env(), obj.InstanceOf(constructor));
}

Object InitObject(Env env) {
Object exports = Object::New(env);

Expand Down Expand Up @@ -265,5 +271,7 @@ Object InitObject(Env env) {
exports["addFinalizer"] = Function::New(env, AddFinalizer);
exports["addFinalizerWithHint"] = Function::New(env, AddFinalizerWithHint);

exports["instanceOf"] = Function::New(env, InstanceOf);

return exports;
}
9 changes: 9 additions & 0 deletions test/object/object.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,4 +137,13 @@ function test(binding) {
circular2: magicObject
});
}

{
function Ctor() {};

assert.strictEqual(binding.object.instanceOf(new Ctor(), Ctor), true);
assert.strictEqual(binding.object.instanceOf(new Ctor(), Object), true);
assert.strictEqual(binding.object.instanceOf({}, Ctor), false);
assert.strictEqual(binding.object.instanceOf(null, Ctor), false);
}
}