Skip to content

test: update BigInt test for recent change in core #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mhdawson wants to merge 1 commit into from
Closed

test: update BigInt test for recent change in core #649

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: update BigInt test for recent change in core 
nodejs/node@689ab46
changed the expected error for one of the BigInt test cases. This is
ok because BigInt is still in experimental. However, the
result was a failed/hanging test. See
nodejs/build#2131

This changes the test to accept either the new or old behaviour.
We need that so that older versions of Node.js will also pass the
test until the the node core commit above is backported.
  • Loading branch information
@mhdawson
mhdawson committed Jan 15, 2020
commit c38baac134cedce5ba7df2a26d334aecbc82b651
4 changes: 2 additions & 2 deletions test/bigint.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ function test(binding) {
});

assert.throws(TestTooBigBigInt, {
name: 'RangeError',
message: 'Maximum BigInt size exceeded',
name: /^(RangeError|Error)$/,
message: /^(Maximum BigInt size exceeded|Invalid argument)$/,
});
}