Skip to content

scope: disallow copying scopes to prevent double close of scopes #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
legendecas wants to merge 1 commit into from
Closed

scope: disallow copying scopes to prevent double close of scopes #565

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
scope: disallow copying scopes to prevent double close of scopes
  • Loading branch information
@legendecas
legendecas committed Oct 15, 2019
commit a8f7fd2719673998242df9d3bd09ca01b421992e
12 changes: 12 additions & 0 deletions napi.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1729,6 +1729,10 @@ namespace Napi {
explicit HandleScope(Napi::Env env);
~HandleScope();

// Disallow copying to prevent double close of napi_handle_scope
HandleScope(HandleScope const &) = delete;
void operator=(HandleScope const &) = delete;

operator napi_handle_scope() const;

Napi::Env Env() const;
Expand All @@ -1744,6 +1748,10 @@ namespace Napi {
explicit EscapableHandleScope(Napi::Env env);
~EscapableHandleScope();

// Disallow copying to prevent double close of napi_escapable_handle_scope
EscapableHandleScope(EscapableHandleScope const &) = delete;
void operator=(EscapableHandleScope const &) = delete;

operator napi_escapable_handle_scope() const;

Napi::Env Env() const;
Expand All @@ -1761,6 +1769,10 @@ namespace Napi {
CallbackScope(napi_env env, napi_async_context context);
virtual ~CallbackScope();

// Disallow copying to prevent double close of napi_callback_scope
CallbackScope(CallbackScope const &) = delete;
void operator=(CallbackScope const &) = delete;

operator napi_callback_scope() const;

Napi::Env Env() const;
Expand Down