Skip to content

test: conditional test experimental features with NODE_MAJOR_VERSION #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mhdawson merged 5 commits into from
Nov 1, 2019
Merged

test: conditional test experimental features with NODE_MAJOR_VERSION #545

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
93348b1
test: conditionally test experimental features with NODE_MAJOR_VERSION
legendecas Sep 18, 2019
890d904
build: remove unnecessary NAPI_VERSION pre-definition on travis
legendecas Sep 22, 2019
988e5c2
src: enabling BigInt API with NAPI_EXPERIMENTAL
legendecas Sep 18, 2019
5fae20a
doc: update comments on test conditions
legendecas Oct 31, 2019
03d6195
Merge branch 'master' into experiment-feature-test
mhdawson Nov 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
build: remove unnecessary NAPI_VERSION pre-definition on travis
  • Loading branch information
@legendecas
legendecas committed Oct 30, 2019
commit 890d90465e7dc9c6f0521f5b1945ff6f4fd9d567
8 changes: 1 addition & 7 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,13 +54,7 @@ install:
script:
# Travis CI sets NVM_NODEJS_ORG_MIRROR, but it makes node-gyp fail to download headers for nightly builds.
- unset NVM_NODEJS_ORG_MIRROR
- NODEJS_MAJOR_VERSION=$(node -p "process.versions.node.match(/\d+/)[0]")

- |
if [ ${NODEJS_MAJOR_VERSION} -gt 11 ]; then
npm test
else
npm test $NPMOPT --NAPI_VERSION=$(node -p "process.versions.napi")
fi
- npm test
after_success:
- cpp-coveralls --gcov-options '\-lp' --build-root test/build --exclude test