chore: do not include component name in tag - #1538
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1538 +/- ##
=======================================
Coverage 64.69% 64.69%
=======================================
Files 3 3
Lines 1997 1997
Branches 687 687
=======================================
Hits 1292 1292
Misses 144 144
Partials 561 561 ☔ View full report in Codecov by Sentry. |
vmoroz
approved these changes
Jul 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default release-please creates a tag with component names: https://github.com/googleapis/release-please/blob/main/docs/manifest-releaser.md#subsequent-versions
There is only one component in the repo so there is no need to include component name in tag name.
Refs: https://github.com/nodejs/node-addon-api/releases/tag/node-addon-api-v8.1.0