Skip to content

test: add second argument to assert.throws() #9987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
russokj wants to merge 1 commit into from
Closed

test: add second argument to assert.throws() #9987

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: add second argument to assert.throws() 
The assert.throws() calls in test-event-emitter-max-listeners.js
should include a constructor or RegExp as a second argument.
  • Loading branch information
@russokj @Trott
russokj authored and Trott committed Dec 24, 2016
commit 6c49a29cb3b436fb47d905a9af62f82ca9d5b0ea
12 changes: 6 additions & 6 deletions test/parallel/test-event-emitter-max-listeners.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
'use strict';
const common = require('../common');
var assert = require('assert');
var events = require('events');
var e = new events.EventEmitter();
const assert = require('assert');
const events = require('events');
const e = new events.EventEmitter();

e.on('maxListeners', common.mustCall(function() {}));

Expand All @@ -11,14 +11,14 @@ e.setMaxListeners(42);

assert.throws(function() {
e.setMaxListeners(NaN);
});
}, /^TypeError: "n" argument must be a positive number$/);

assert.throws(function() {
e.setMaxListeners(-1);
});
}, /^TypeError: "n" argument must be a positive number$/);

assert.throws(function() {
e.setMaxListeners('and even this');
});
}, /^TypeError: "n" argument must be a positive number$/);

e.emit('maxListeners');