Skip to content

tests: update test-tls-no-cert-required #9969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rajapanidepu wants to merge 1 commit into from
Closed

tests: update test-tls-no-cert-required #9969

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
tests: update test-tls-no-cert-required 
Change var to const.
Wrap callback of createServer with common.mustCall.
  • Loading branch information
Raja Panidepu committed Dec 1, 2016
commit d5d7db4a868ae02bcf08b230f42e8b752d1511af
11 changes: 6 additions & 5 deletions test/parallel/test-tls-no-cert-required.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
'use strict';
var common = require('../common');
const common = require('../common');

if (!common.hasCrypto) {
common.skip('missing crypto');
return;
}
var tls = require('tls');
const tls = require('tls');

// Omitting the cert or pfx option to tls.createServer() should not throw.
// AECDH-NULL-SHA is a no-authentication/no-encryption cipher and hence
// doesn't need a certificate.
tls.createServer({ ciphers: 'AECDH-NULL-SHA' }).listen(0, function() {
this.close();
});
tls.createServer({ ciphers: 'AECDH-NULL-SHA' })
.listen(0, common.mustCall(function() {
Copy link
Copy Markdown
Contributor

@cjihrig cjihrig Dec 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

common.mustCall() is not needed here. If the callback is not called, the server won't be closed, and the test will timeout.

this.close();
}));