Skip to content

test: Change equal to strictEqual and pass delay to setTimeout #9938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
qualquervalor2 wants to merge 3 commits into from
Closed

test: Change equal to strictEqual and pass delay to setTimeout #9938

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3c78fb5
test: change equal to strictEqual, fix setTimeout
Dec 1, 2016
89b0369
Update timeout delay to 1ms
Dec 2, 2016
80c2aec
Update timeout to use mustCall
Dec 6, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: change equal to strictEqual, fix setTimeout
  • Loading branch information
Chris Henney authored and Chris Henney committed Dec 1, 2016
commit 3c78fb548e10c2c1058a962fbcc3545de10ced57
6 changes: 3 additions & 3 deletions test/parallel/test-domain-exit-dispose.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ function err() {
console.error('This should not happen.');
disposalFailed = true;
process.exit(1);
});
}, 0);
Copy link
Copy Markdown
Contributor

@Fishrock123 Fishrock123 Dec 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qualquervalor2 Could you check if this works with setImmediate() instead of setTimeout()?

If it doesn't work, could you change the 0 to a 1? The 0 becomes a 1 under the hood so it would be better to be explicit up front. :)

Copy link
Copy Markdown
Author

@qualquervalor2 qualquervalor2 Dec 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setImediate() did not work. Updated the PR to use 1.


// this function doesn't exist, and throws an error as a result.
err3(); // eslint-disable-line no-undef
Expand All @@ -41,7 +41,7 @@ function err() {
}

process.on('exit', function() {
assert.equal(a, 10);
assert.equal(disposalFailed, false);
assert.strictEqual(a, 10);
assert.strictEqual(disposalFailed, false);
console.log('ok');
});